Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1175230?usp=email )
Change subject: Revert: Proceed Login CI tests wit all other actions are completed ...................................................................... Revert: Proceed Login CI tests wit all other actions are completed This never works if jobs are restarted because it waits for itself but the previous login_tests-ci.yml has never started and was marked as failed. Also remove printing the IP. Change-Id: I891a5a9574a47576ef6c5baac9e4370f92d4e350 --- M .github/workflows/login_tests-ci.yml M .github/workflows/oauth_tests-ci.yml M .github/workflows/pywikibot-ci.yml 3 files changed, 0 insertions(+), 16 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/.github/workflows/login_tests-ci.yml b/.github/workflows/login_tests-ci.yml index 7f1d29e..b69dd85 100644 --- a/.github/workflows/login_tests-ci.yml +++ b/.github/workflows/login_tests-ci.yml @@ -14,19 +14,8 @@ PYWIKIBOT_USERNAME: Pywikibot-test jobs: - wait_for_all: - runs-on: ubuntu-latest - steps: - - name: Wait for all workflows to complete - uses: kachick/[email protected] - with: - warmup-delay: PT1M - minimum-interval: PT5M - - name: Proceed with tests - run: echo "All workflows have completed. Proceeding with Login CI tests." run_tests: runs-on: ${{ matrix.os || 'ubuntu-latest' }} - needs: wait_for_all timeout-minutes: 30 strategy: fail-fast: false diff --git a/.github/workflows/oauth_tests-ci.yml b/.github/workflows/oauth_tests-ci.yml index 91725cc..0aa7e33 100644 --- a/.github/workflows/oauth_tests-ci.yml +++ b/.github/workflows/oauth_tests-ci.yml @@ -79,9 +79,6 @@ pip install mwoauth pip install packaging pip install requests - - name: Print public IP of runner - run: | - python -c "import urllib.request; print('Public IP:', urllib.request.urlopen('https://api.ipify.org').read().decode('utf-8'))" - name: Generate family files if: ${{ matrix.family == 'wpbeta' }} run: | diff --git a/.github/workflows/pywikibot-ci.yml b/.github/workflows/pywikibot-ci.yml index f359b03..114fb7b 100644 --- a/.github/workflows/pywikibot-ci.yml +++ b/.github/workflows/pywikibot-ci.yml @@ -148,6 +148,4 @@ - name: Check on failure if: steps.ci_test.outcome == 'failure' run: | - # Print public IP of runner - python -c "import urllib.request; print('Public IP:', urllib.request.urlopen('https://api.ipify.org').read().decode('utf-8'))" exit 1 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1175230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I891a5a9574a47576ef6c5baac9e4370f92d4e350 Gerrit-Change-Number: 1175230 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <[email protected]> Gerrit-Reviewer: Xqt <[email protected]> Gerrit-Reviewer: jenkins-bot
_______________________________________________ Pywikibot-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
