jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1172860?usp=email )
Change subject: Cleanup: remove Flow tests parts
......................................................................
Cleanup: remove Flow tests parts
Bug: T107537
Bug: T381551
Change-Id: I1c2e1684fe3c863e9d09369ddda274e9dd55e4c7
---
M tests/basepage.py
1 file changed, 4 insertions(+), 11 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/basepage.py b/tests/basepage.py
index 651569b..975d30e 100644
--- a/tests/basepage.py
+++ b/tests/basepage.py
@@ -40,7 +40,7 @@
super().setUp()
assert self.cached is False, 'Tests do not support caching'
- def _test_page_text(self, get_text=True) -> None:
+ def _test_page_text(self) -> None:
"""Test site.loadrevisions() with .text."""
page = self._page
@@ -84,23 +84,16 @@
loadrevisions = self.site.loadrevisions
try:
self.site.loadrevisions = None
- if get_text:
- loaded_text = page.text
- else: # T107537
- with self.assertRaises(NotImplementedError):
- page.text
- loaded_text = ''
+ loaded_text = page.text
self.assertIsNotNone(loaded_text)
self.assertNotHasAttr(page, '_text')
page.text = custom_text
- if get_text:
- self.assertEqual(page.get(), loaded_text)
+ self.assertEqual(page.get(), loaded_text)
self.assertEqual(page._text, custom_text)
self.assertEqual(page.text, page._text)
del page.text
self.assertNotHasAttr(page, '_text')
- if get_text:
- self.assertEqual(page.text, loaded_text)
+ self.assertEqual(page.text, loaded_text)
finally:
self.site.loadrevisions = loadrevisions
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1172860?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I1c2e1684fe3c863e9d09369ddda274e9dd55e4c7
Gerrit-Change-Number: 1172860
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
