jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1155193?usp=email )
Change subject: IMPR: Don't fix broken redirects if namespace of source and
target are different
......................................................................
IMPR: Don't fix broken redirects if namespace of source and target are different
Bug: T396456
Change-Id: Id961b4598b99e09e6bf48d18d632da839f3a143c
---
M scripts/redirect.py
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/redirect.py b/scripts/redirect.py
index 3b84d73..83fd030 100755
--- a/scripts/redirect.py
+++ b/scripts/redirect.py
@@ -12,12 +12,18 @@
:double: Shortcut: **do**. Fix redirects which point to other redirects.
-:broken: Shortcut: **br**. Tries to fix redirect which point to nowhere
- by using the last moved target of the destination page. If this
- fails and the -delete option is set, it either deletes the page
- or marks it for deletion depending on whether the account has
- admin rights. It will mark the redirect not for deletion if
- there is no speedy deletion template available.
+:broken: Shortcut: **br**. Tries to fix redirect which point to
+ nowhere by using the last moved target of the source page
+ and both have the same namespace. If this fails and the
+ *-delete* option is set, it either deletes the page or
+ marks it for deletion depending on whether the account
+ has delete rights. It will mark the redirect not for
+ deletion if there is no speedy deletion template
+ available.
+
+ .. versionchanged:: 10.3
+ only tries to fix if the namspace of the source page
+ is equal to the destination page.
:both: Both of the above. Retrieves redirect pages from live wiki,
not from a special page.
@@ -515,6 +521,9 @@
if not movedTarget.exists():
# FIXME: Test to another move
pywikibot.info(f'Target page {movedTarget} does not exist')
+ elif redir_page.namespace() != movedTarget.namespace():
+ pywikibot.info(f'Namespace of {redir_page} is different'
+ f'from target page {movedTarget}')
elif redir_page == movedTarget:
pywikibot.info(
'Redirect to target page forms a redirect loop')
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1155193?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Id961b4598b99e09e6bf48d18d632da839f3a143c
Gerrit-Change-Number: 1155193
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
