jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1156282?usp=email )
Change subject: tests: add pbab tasks hints to expectedFailure decorators
......................................................................
tests: add pbab tasks hints to expectedFailure decorators
Also remove skip decorator from
pagegenerators_tests.TestLinksearchPageGenerator.test_weblink and replace
it with expectedFailure
Bug: T396728
Bug: T129368
Change-Id: Ic313f81051c24e0d02b28369df87188ef45d98a6
---
M tests/cosmetic_changes_tests.py
M tests/file_tests.py
M tests/pagegenerators_tests.py
M tests/textlib_tests.py
M tests/time_tests.py
M tests/wikibase_tests.py
6 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/cosmetic_changes_tests.py b/tests/cosmetic_changes_tests.py
index f616540..8bdeba2 100755
--- a/tests/cosmetic_changes_tests.py
+++ b/tests/cosmetic_changes_tests.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
"""Test cosmetic_changes module."""
#
-# (C) Pywikibot team, 2015-2024
+# (C) Pywikibot team, 2015-2025
#
# Distributed under the terms of the MIT license.
#
@@ -432,7 +432,7 @@
'[[File:Foo.bar|250px|zentriert|Bar]]',
self.cct.translateMagicWords('[[File:Foo.bar|250px|center|Bar]]'))
- @unittest.expectedFailure
+ @unittest.expectedFailure # T396715
def test_translateMagicWords_fail(self) -> None:
"""Test translateMagicWords method.
@@ -470,7 +470,7 @@
self.assertEqual('[[sand]]box',
self.cct.cleanUpLinks('[[Sand|sand]]box'))
- @unittest.expectedFailure
+ @unittest.expectedFailure # T396714
def test_cleanup_links(self) -> None:
"""Test cleanUpLinks method.
diff --git a/tests/file_tests.py b/tests/file_tests.py
index 27acf1f..6386c8b 100755
--- a/tests/file_tests.py
+++ b/tests/file_tests.py
@@ -247,7 +247,7 @@
'https://upload.wikimedia.org/wikipedia/commons/'
'd/d3/Albert_Einstein_Head.jpg')
- @unittest.expectedFailure
+ @unittest.expectedFailure # T391761
def test_get_file_url_thumburl_from_width(self) -> None:
"""Get File thumburl from width."""
self.assertTrue(self.image.exists())
@@ -259,7 +259,7 @@
self.assertEqual(self.image.latest_file_info.thumbwidth, 100)
self.assertEqual(self.image.latest_file_info.thumbheight, 133)
- @unittest.expectedFailure
+ @unittest.expectedFailure # T391761
def test_get_file_url_thumburl_from_height(self) -> None:
"""Get File thumburl from height."""
self.assertTrue(self.image.exists())
@@ -271,7 +271,7 @@
self.assertEqual(self.image.latest_file_info.thumbwidth, 75)
self.assertEqual(self.image.latest_file_info.thumbheight, 100)
- @unittest.expectedFailure
+ @unittest.expectedFailure # T391761
def test_get_file_url_thumburl_from_url_param(self) -> None:
"""Get File thumburl from height."""
self.assertTrue(self.image.exists())
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 29aee4e..2adaba4 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1726,7 +1726,7 @@
family = 'wikipedia'
code = 'en'
- @unittest.skip('Needs to be adapted for T14810')
+ @unittest.expectedFailure # T396728
def test_weblink(self) -> None:
"""Test -weblink."""
cases = (('wikipedia.org', 'http://wikipedia.org'),
diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py
index 18324ca..e482ba2 100755
--- a/tests/textlib_tests.py
+++ b/tests/textlib_tests.py
@@ -71,7 +71,7 @@
self.assertNotContains('Minor_Edits',
'section hashes are case-sensitive')
- @unittest.expectedFailure # TODO: T133276
+ @unittest.expectedFailure # T133276
def test_encoded_chars_in_section(self) -> None:
"""Test encoded chars in section."""
self.assertContains('Talk_.28discussion.29_pages',
@@ -874,7 +874,7 @@
self.get_site('wt')),
'[[Bar]] and [[Bar|bar]]')
- @unittest.expectedFailure
+ @unittest.expectedFailure # T396719
def test_label_diff_namespace(self) -> None:
"""Test that it uses the old label when the new doesn't match."""
# These tests require to get the actual part which is before the title
@@ -1369,7 +1369,7 @@
'x', 'y', ['file'], site=self.site),
'[[File:a|[[foo]] [[bar [invalid ]].x]][[y]]')
- @unittest.expectedFailure
+ @unittest.expectedFailure # T396721
def test_replace_tag_file_failure(self) -> None:
"""Test showing limits of the file link regex."""
# When the double brackets are unbalanced, the regex
diff --git a/tests/time_tests.py b/tests/time_tests.py
index b3ec13a..3e682cf 100755
--- a/tests/time_tests.py
+++ b/tests/time_tests.py
@@ -163,7 +163,7 @@
self.assertEqual(date, str(t1.date()))
self.assertEqual(time, str(t1.time()))
- @unittest.expectedFailure
+ @unittest.expectedFailure # T396723
def test_iso_format_with_sep(self) -> None:
"""Test conversion from and to ISO format with separator."""
sep = '*'
diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py
index cf0c0bb..c590298 100755
--- a/tests/wikibase_tests.py
+++ b/tests/wikibase_tests.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
"""Tests for the Wikidata parts of the page module."""
#
-# (C) Pywikibot team, 2008-2024
+# (C) Pywikibot team, 2008-2025
#
# Distributed under the terms of the MIT license.
#
@@ -716,7 +716,7 @@
self.assertEqual(claim.type, 'wikibase-property')
self.assertEqual(claim.target, property_page)
- @unittest.expectedFailure
+ @unittest.expectedFailure # T145971
def test_exists(self) -> None:
"""Test the exists method of PropertyPage."""
wikidata = self.get_repo()
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1156282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic313f81051c24e0d02b28369df87188ef45d98a6
Gerrit-Change-Number: 1156282
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]