jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1096500?usp=email )
Change subject: IMPR: use list comprehensions instead of for loops
......................................................................
IMPR: use list comprehensions instead of for loops
Change-Id: I83654f9f51c6834e07f7ae2e2d0bb26ebfbac014
---
M pywikibot/page/_page.py
M scripts/upload.py
M tests/__init__.py
M tests/pagegenerators_tests.py
M tests/uploadbot_tests.py
5 files changed, 17 insertions(+), 14 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page/_page.py b/pywikibot/page/_page.py
index 199d4d6..6e5f277 100644
--- a/pywikibot/page/_page.py
+++ b/pywikibot/page/_page.py
@@ -117,8 +117,7 @@
named[str(k)] = v
break
- for item in named.items():
- positional.append('{}={}'.format(*item))
+ positional += [f'{key}={value}' for key, value in named.items()]
result.append((pywikibot.Page(link, self.site), positional))
return result
diff --git a/scripts/upload.py b/scripts/upload.py
index a64ef92..c766801 100755
--- a/scripts/upload.py
+++ b/scripts/upload.py
@@ -222,8 +222,9 @@
if not recursive:
# Do not visit any subdirectories
directory_info[1][:] = []
- for dir_file in directory_info[2]:
- file_list.append(os.path.join(directory_info[0], dir_file))
+
+ file_list += [os.path.join(directory_info[0], dir_file)
+ for dir_file in directory_info[2]]
url = file_list
else:
url = [url]
diff --git a/tests/__init__.py b/tests/__init__.py
index 2c51f5f..3fc5d44 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -239,12 +239,12 @@
discovered = loader.loadTestsFromName(module_class_name)
enabled_tests = []
for cls in discovered:
- for test_func in cls:
- if test_func._testMethodName not in disabled_tests[module]:
- enabled_tests.append(
- module_class_name + '.'
- + test_func.__class__.__name__ + '.'
- + test_func._testMethodName)
+ enabled_tests += [
+ f'{module_class_name}.{type(test_func).__name__}.'
+ f'{test_func._testMethodName}'
+ for test_func in cls
+ if test_func._testMethodName not in disabled_tests[module]
+ ]
test_list.extend(enabled_tests)
else:
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index e3ba1ed..c7cee26 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -546,8 +546,10 @@
expected = []
for month in range(start_month, end_month + 1):
- for day in range(1, calendar.monthrange(year, month)[1] + 1):
- expected.append(date.format_date(month, day, self.site))
+ expected += [
+ date.format_date(month, day, self.site)
+ for day in range(1, calendar.monthrange(year, month)[1] + 1)
+ ]
self.assertPageTitlesEqual(gen2, expected)
diff --git a/tests/uploadbot_tests.py b/tests/uploadbot_tests.py
index 9c286ba..4c7e943 100755
--- a/tests/uploadbot_tests.py
+++ b/tests/uploadbot_tests.py
@@ -39,8 +39,9 @@
"""Test uploading a list of pngs using upload.py."""
image_list = []
for directory_info in os.walk(join_images_path()):
- for dir_file in directory_info[2]:
- image_list.append(os.path.join(directory_info[0], dir_file))
+ image_list += [os.path.join(directory_info[0], dir_file)
+ for dir_file in directory_info[2]]
+
bot = UploadRobot(url=image_list, target_site=self.get_site(),
**self.params)
bot.run()
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1096500?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I83654f9f51c6834e07f7ae2e2d0bb26ebfbac014
Gerrit-Change-Number: 1096500
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
