jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1096314?usp=email )
Change subject: IMPR: use target.items() to get key/value pairs in
create_isbn_edition.py
......................................................................
IMPR: use target.items() to get key/value pairs in create_isbn_edition.py
Change-Id: I625d0cfd60da54c0b65d277637f757c97217ca99
---
M scripts/create_isbn_edition.py
1 file changed, 9 insertions(+), 10 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/create_isbn_edition.py b/scripts/create_isbn_edition.py
index e33c5f2..eeafa91 100755
--- a/scripts/create_isbn_edition.py
+++ b/scripts/create_isbn_edition.py
@@ -935,7 +935,6 @@
def add_claims(isbn_data: dict[str, Any]) -> int: # noqa: C901
"""Inspect isbn_data and add claims if possible."""
- global proptyx
# targetx is not global (to allow for language specific editions)
# Set default language from book library
@@ -1096,13 +1095,13 @@
# Register missing statements
pywikibot.debug(target)
- for propty in target:
+ for propty, title in target.items():
if propty not in item.claims:
if propty not in proptyx:
proptyx[propty] = pywikibot.PropertyPage(repo, propty)
# Target could get overwritten locally
- targetx[propty] = pywikibot.ItemPage(repo, target[propty])
+ targetx[propty] = pywikibot.ItemPage(repo, title)
claim = pywikibot.Claim(repo, propty)
claim.setTarget(targetx[propty])
@@ -1110,7 +1109,7 @@
pywikibot.warning(
f'Add {get_item_header_lang(proptyx[propty].labels, booklang)}'
f':{get_item_header_lang(targetx[propty].labels, booklang)} '
- f'({propty}:{target[propty]})'
+ f'({propty}:{title})'
)
# Set source reference
@@ -1675,14 +1674,14 @@
targetx = {}
# Validate and encode the propery/instance pair
- for propty in target:
+ for propty, title in target.items():
if propty not in proptyx:
proptyx[propty] = pywikibot.PropertyPage(repo, propty)
- if target[propty] != '-':
- targetx[propty] = get_item_page(target[propty])
+ if title != '-':
+ targetx[propty] = get_item_page(title)
pywikibot.info(f'Add {get_item_header(proptyx[propty].labels)}:'
f'{get_item_header(targetx[propty].labels)} '
- f'({propty}:{target[propty]})')
+ f'({propty}:{title})')
# Check the instance type for P/Q pairs (critical)
if (propty in propreqinst
@@ -1690,7 +1689,7 @@
or not item_is_in_list(targetx[propty].claims[INSTANCEPROP],
propreqinst[propty]))):
pywikibot.critical(
- f'{get_item_header(targetx[propty].labels)} ({target[propty]})'
+ f'{get_item_header(targetx[propty].labels)} ({title})'
f' is not one of instance type {propreqinst[propty]} for '
f'statement {get_item_header(proptyx[propty].labels)} '
f'({propty})'
@@ -1703,7 +1702,7 @@
and not item_is_in_list(targetx[propty].claims,
propreqobjectprop[propty])):
pywikibot.error(
- f'{get_item_header(targetx[propty].labels)} ({target[propty]})'
+ f'{get_item_header(targetx[propty].labels)} ({title})'
f' does not have property {propreqobjectprop[propty]} for '
f'statement {get_item_header(proptyx[propty].labels)} '
f'({propty})'
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1096314?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I625d0cfd60da54c0b65d277637f757c97217ca99
Gerrit-Change-Number: 1096314
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Geertivp <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
