Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/988662 )
Change subject: fix test for bulba:bulba wiki
......................................................................
fix test for bulba:bulba wiki
Bug: T354535
Change-Id: I19eba388388698452b9a2f957376fa456c11c342
---
M tests/link_tests.py
1 file changed, 34 insertions(+), 8 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/tests/link_tests.py b/tests/link_tests.py
index f2df2b6..ad15a9e 100755
--- a/tests/link_tests.py
+++ b/tests/link_tests.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
"""Test Link functionality."""
#
-# (C) Pywikibot team, 2014-2022
+# (C) Pywikibot team, 2014-2024
#
# Distributed under the terms of the MIT license.
#
@@ -866,21 +866,37 @@
code = 'en'
def test_non_wiki_prefix(self):
- """Test that Link fails if the interwiki prefix is not a wiki."""
+ """Test that Link fails if the interwiki prefix is not a wiki.
+
+ *bugzilla* does not return a json content but redirects to phab.
+ api.Request._json_loads cannot detect this problem and raises a
+ :exc:`exceptions.SiteDefinitionError`. The site is created
+ anyway but the title cannot be parsed:
+ """
link = Link('bugzilla:1337', source=self.site)
- # bugzilla does not return a json content but redirects to phab.
- # api.Request._json_loads cannot detect this problem and raises
- # a SiteDefinitionError. The site is created anyway but the title
- # cannot be parsed
with self.assertRaises(SiteDefinitionError):
link.site
self.assertEqual(link.site.sitename, 'wikimedia:wikimedia')
self.assertTrue(link._is_interwiki)
def test_other_wiki_prefix(self):
- """Test that Link fails if the interwiki prefix is a unknown family."""
+ """Test that Link fails if the interwiki prefix is a unknown family.
+
+ Sometimes *bulba* does not return a json content but a security
+ script. api.Request._json_loads raises a
+ :exc:`exceptions.SiteDefinitionError` for an invalid
+ :class:`Autofamily('bulbapedia.bulbagarden.net')
+ <family.AutoFamily>`. The site is created anyway but the title
+ cannot be parsed in such case.
+ """
link = Link('bulba:title on auto-generated Site', source=self.site)
- self.assertEqual(link.title, 'Title on auto-generated Site')
+ try:
+ link.site
+ except SiteDefinitionError as e:
+ self.assertEqual(
+ str(e), "Invalid AutoFamily('bulbapedia.bulbagarden.net')")
+ else:
+ self.assertEqual(link.title, 'Title on auto-generated Site')
self.assertEqual(link.site.sitename, 'bulba:bulba')
self.assertTrue(link._is_interwiki)
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/988662
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I19eba388388698452b9a2f957376fa456c11c342
Gerrit-Change-Number: 988662
Gerrit-PatchSet: 5
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
