Xqt has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/980504 )

Change subject: [IMPR] Fix type hints in _filepage.py
......................................................................

[IMPR] Fix type hints in _filepage.py

Change-Id: Ia836613ec8c362a977cf07d0ede343ed87562086
---
M pywikibot/page/_filepage.py
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Xqt: Verified; Looks good to me, approved




diff --git a/pywikibot/page/_filepage.py b/pywikibot/page/_filepage.py
index deb0bf3..0503454 100644
--- a/pywikibot/page/_filepage.py
+++ b/pywikibot/page/_filepage.py
@@ -161,7 +161,7 @@
     def get_file_url(self,
                      url_width: Optional[int] = None,
                      url_height: Optional[int] = None,
-                     url_param: Optional[int] = None) -> str:
+                     url_param: Optional[str] = None) -> str:
         """Return the url or the thumburl of the file described on this page.

         Fetch the information if not available.
@@ -330,7 +330,7 @@
                  revision: Optional['FileInfo'] = None, *,
                  url_width: Optional[int] = None,
                  url_height: Optional[int] = None,
-                 url_param: Optional[int] = None) -> bool:
+                 url_param: Optional[str] = None) -> bool:
         """Download to filename file of FilePage.

         **Usage examples:**

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/980504
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ia836613ec8c362a977cf07d0ede343ed87562086
Gerrit-Change-Number: 980504
Gerrit-PatchSet: 1
Gerrit-Owner: Mpaa <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to