jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908944 )
Change subject: [IMPR] None as default value can be omitted with dict.get()
......................................................................
[IMPR] None as default value can be omitted with dict.get()
Change-Id: I18650a58b1bd205f251d1eda397b3b1778dd9f5d
---
M pywikibot/page/_wikibase.py
M pywikibot/echo.py
M pywikibot/site/_basesite.py
3 files changed, 13 insertions(+), 4 deletions(-)
Approvals:
Matěj Suchánek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/echo.py b/pywikibot/echo.py
index 18112da..9d271ee 100644
--- a/pywikibot/echo.py
+++ b/pywikibot/echo.py
@@ -59,8 +59,8 @@
except KeyError:
notif.read = False
- notif.content = data.get('*', None)
- notif.revid = data.get('revid', None)
+ notif.content = data.get('*')
+ notif.revid = data.get('revid')
return notif
def mark_as_read(self) -> bool:
diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py
index 0e278c8..d7e9f5c 100644
--- a/pywikibot/page/_wikibase.py
+++ b/pywikibot/page/_wikibase.py
@@ -1579,7 +1579,7 @@
"""
claim_repo = site.get_repo_for_entity_type('property')
claim = cls(claim_repo, data['mainsnak']['property'],
- datatype=data['mainsnak'].get('datatype', None))
+ datatype=data['mainsnak'].get('datatype'))
if 'id' in data:
claim.snak = data['id']
elif 'hash' in data:
diff --git a/pywikibot/site/_basesite.py b/pywikibot/site/_basesite.py
index c0311d3..a5f92df 100644
--- a/pywikibot/site/_basesite.py
+++ b/pywikibot/site/_basesite.py
@@ -414,7 +414,7 @@
def interwiki_putfirst(self):
"""Return list of language codes for ordering of interwiki links."""
- return self.family.interwiki_putfirst.get(self.code, None)
+ return self.family.interwiki_putfirst.get(self.code)
def getSite(self, code): # noqa: N802
"""Return Site object for language 'code' in this Family."""
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908944
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I18650a58b1bd205f251d1eda397b3b1778dd9f5d
Gerrit-Change-Number: 908944
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Matěj Suchánek <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
