jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908829 )
Change subject: [tests] Remove obsolete sites from TestGenerateFamilyFiles test
......................................................................
[tests] Remove obsolete sites from TestGenerateFamilyFiles test
Closed wikis may not have a main page and the test will fail in such
case. Remove obsolete wikis from CountEqual test but add one to test
this behaviour
Bug: T334714
Change-Id: Iafbabb24e2ed96c952557cb68149e0faf28fddbc
---
M tests/generate_family_file_tests.py
1 file changed, 23 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/generate_family_file_tests.py
b/tests/generate_family_file_tests.py
index 07cd30a..f219ac6 100755
--- a/tests/generate_family_file_tests.py
+++ b/tests/generate_family_file_tests.py
@@ -24,6 +24,11 @@
"""Only load up to additional ten different wikis randomly."""
save = self.langs
self.langs = sample(save, min(len(save), 10))
+ for wiki in save: # add closed wiki due to T334714
+ if wiki['prefix'] == 'ii' and 'ii' not in self.langs:
+ self.langs.append(wiki)
+ break
+
self.prefixes = [item['prefix'] for item in self.langs]
super().getapis()
self.langs = save
@@ -74,8 +79,10 @@
if self.site.family.name not in ('wsbeta', 'musicbrainz'):
with self.subTest(test='Test element counts'):
if self.site.lang not in gen.prefixes:
- gen.prefixes += [self.site.lang]
- self.assertCountEqual(gen.prefixes, gen.wikis)
+ gen.prefixes.append(self.site.lang)
+ obsolete = self.site.family.interwiki_removals
+ self.assertCountEqual(set(gen.prefixes) - obsolete,
+ set(gen.wikis) - obsolete)
# test creating Site from url
# only test Sites for downloaded wikis (T241413)
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/908829
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Iafbabb24e2ed96c952557cb68149e0faf28fddbc
Gerrit-Change-Number: 908829
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
