jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/873037 )
Change subject: CategoryListifyRobot: refactor `prefix`
......................................................................
CategoryListifyRobot: refactor `prefix`
use options and kwargs, reduce number of function arguments to make
code more generic and clean
Change-Id: Ib067a6366a13dd29ad721105f5a4b7938ba9bd2e
---
M scripts/category.py
1 file changed, 18 insertions(+), 7 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/category.py b/scripts/category.py
index 6923a4a..9046ce2 100755
--- a/scripts/category.py
+++ b/scripts/category.py
@@ -982,8 +982,8 @@
show_images: bool = False, *,
talk_pages: bool = False,
recurse: Union[int, bool] = False,
- prefix: str = '*',
- namespaces=None) -> None:
+ namespaces=None,
+ **kwargs) -> None:
"""Initializer."""
self.edit_summary = edit_summary
self.append = append
@@ -1000,7 +1000,7 @@
self.list = pywikibot.Page(self.site, list_title)
self.talk_pages = talk_pages
self.recurse = recurse
- self.prefix = prefix
+ self.prefix = kwargs.pop('prefix', '*')
self.namespaces = self.site.namespaces.resolve(namespaces or [])
self.subcats = not self.namespaces or 'Category' in self.namespaces
@@ -1510,7 +1510,6 @@
move_together = False
keep_sortkey = None
depth = 5
- prefix = '*'
# Process global args and prepare generator args parser
local_args = pywikibot.handle_args(args)
@@ -1585,7 +1584,7 @@
elif option == 'keepsortkey':
keep_sortkey = True
elif option == 'prefix':
- prefix = value
+ options[option] = value
elif option == 'always':
options[option] = True
else:
@@ -1669,8 +1668,8 @@
append, overwrite, showimages,
talk_pages=talkpages,
recurse=options.get('recurse', False),
- prefix=prefix,
- namespaces=gen_factory.namespaces)
+ namespaces=gen_factory.namespaces,
+ **options)
elif action == 'clean':
bot = CleanBot(**options)
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/873037
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ib067a6366a13dd29ad721105f5a4b7938ba9bd2e
Gerrit-Change-Number: 873037
Gerrit-PatchSet: 2
Gerrit-Owner: Costa Shul <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
