jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/771983 )
Change subject: [R0201] Make httpError and getPDFTitle a static method
......................................................................
[R0201] Make httpError and getPDFTitle a static method
Change-Id: I532272dc35bc38ddfa4f1154164bb36d3eec3ec6
---
M scripts/reflinks.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
D3r1ck01: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/reflinks.py b/scripts/reflinks.py
index 6e7aba8..e0706dc 100755
--- a/scripts/reflinks.py
+++ b/scripts/reflinks.py
@@ -494,12 +494,14 @@
self.MIME = re.compile(
r'application/(?:xhtml\+xml|xml)|text/(?:ht|x)ml')
- def httpError(self, err_num, link, pagetitleaslink) -> None:
+ @staticmethod
+ def httpError(err_num, link, pagetitleaslink) -> None:
"""Log HTTP Error."""
pywikibot.stdout('HTTP error ({}) for {} on {}'
.format(err_num, link, pagetitleaslink))
- def getPDFTitle(self, ref, response) -> None:
+ @staticmethod
+ def getPDFTitle(ref, response) -> None:
"""Use pdfinfo to retrieve title from a PDF."""
# pdfinfo is Unix-only
pywikibot.output('Reading PDF file...')
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/771983
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I532272dc35bc38ddfa4f1154164bb36d3eec3ec6
Gerrit-Change-Number: 771983
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
