jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/771845 )
Change subject: [IMPR] Simplify creation of page._protection dict
......................................................................
[IMPR] Simplify creation of page._protection dict
Change-Id: I90b11d5ff1121c37036109e9505e0083be5c7c08
---
M pywikibot/site/_obsoletesites.py
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site/_obsoletesites.py b/pywikibot/site/_obsoletesites.py
index c5f0a50..ee44cbd 100644
--- a/pywikibot/site/_obsoletesites.py
+++ b/pywikibot/site/_obsoletesites.py
@@ -5,6 +5,7 @@
# Distributed under the terms of the MIT license.
#
import pywikibot
+from pywikibot.backports import Dict, Tuple
from pywikibot.exceptions import NoPageError
from pywikibot.site._apisite import APISite
from pywikibot.site._basesite import BaseSite
@@ -27,23 +28,22 @@
pywikibot.error('Site {} has been closed. {}'.format(self.sitename,
notice))
- def page_restrictions(self, page):
+ def page_restrictions(
+ self, page: 'pywikibot.Page') -> Dict[str, Tuple[str, str]]:
"""Return a dictionary reflecting page protections."""
if not page.exists():
raise NoPageError(page)
if not hasattr(page, '_protection'):
- page._protection = {'edit': ('steward', 'infinity'),
- 'move': ('steward', 'infinity'),
- 'delete': ('steward', 'infinity'),
- 'upload': ('steward', 'infinity'),
- 'create': ('steward', 'infinity')}
+ page._protection = dict.fromkeys(
+ ('create', 'delete', 'edit', 'move', 'upload'),
+ ('steward', 'infinity'))
return page._protection
def recentchanges(self, **kwargs) -> None:
"""An error instead of pointless API call."""
self._closed_error('No recent changes can be returned.')
- def is_uploaddisabled(self):
+ def is_uploaddisabled(self) -> bool:
"""Return True if upload is disabled on site."""
if not hasattr(self, '_uploaddisabled'):
self._uploaddisabled = True
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/771845
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I90b11d5ff1121c37036109e9505e0083be5c7c08
Gerrit-Change-Number: 771845
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
