Xqt has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/768165 )

Change subject: Revert "[tests] Upload coverage file even if tests fails"
......................................................................

Revert "[tests] Upload coverage file even if tests fails"

This reverts commit d1ebb5c756f10994cfbd4729008767a2b631afa7.

Reason for revert: yml file error

Change-Id: Ie35b5008a82874b764c9439ca29eb763193e7b79
---
M .github/workflows/pywikibot-ci.yml
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Xqt: Verified; Looks good to me, approved



diff --git a/.github/workflows/pywikibot-ci.yml 
b/.github/workflows/pywikibot-ci.yml
index 37d8f6c..d814284 100644
--- a/.github/workflows/pywikibot-ci.yml
+++ b/.github/workflows/pywikibot-ci.yml
@@ -111,8 +111,6 @@
         echo "('${{ env.PYWIKIBOT_USERNAME }}', '${{ secrets.PYWIKIBOT_USERPWD 
}}')" > passwordfile

     - name: Test with unittest or pytest
-      id: ci_test
-      continue-on-error: true
       env:
         PYWIKIBOT_TEST_NO_RC:
           ${{ (matrix.site == 'wikisource:zh' || matrix.test_no_rc) && 1 || 0 
}}
@@ -127,8 +125,5 @@
         fi

     - name: Upload coverage to Codecov
+      continue-on-error: true
       run: codecov
-
-    - name: Check on failure
-      if steps.ci_test.outcome == 'failure'
-      run exit 1

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/768165
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ie35b5008a82874b764c9439ca29eb763193e7b79
Gerrit-Change-Number: 768165
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to