jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/759717 )

Change subject: [cleanup] Remove showHelp function and BaseBot.stop method
......................................................................

[cleanup] Remove showHelp function and BaseBot.stop method

Both were deprecated since Pywikibot 4.0.0

Change-Id: I4a72f6d7231a2accfd0f38d2d50ea338ebf5201c
---
M pywikibot/bot.py
1 file changed, 1 insertion(+), 17 deletions(-)

Approvals:
  JJMC89: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index df367b0..00fe1fb 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -75,7 +75,7 @@
     'QuitKeyboardInterrupt',
     'InteractiveReplace',
     'calledModuleName', 'handle_args',
-    'show_help', 'showHelp', 'suggest_help',
+    'show_help', 'suggest_help',
     'writeToCommandLogFile', 'open_webbrowser',
     'OptionHandler',
     'BaseBot', 'Bot', 'ConfigParserBot', 'SingleSiteBot', 'MultipleSitesBot',
@@ -1022,12 +1022,6 @@
         pywikibot.stdout(_GLOBAL_HELP_NOTE)


-@deprecated('show_help', since='20200705')
-def showHelp(module_name: Optional[str] = None) -> None:  # pragma: no cover
-    """DEPRECATED. Show help for the Bot."""
-    return show_help(module_name)
-
-
 def suggest_help(missing_parameters: Optional[Sequence[str]] = None,
                  missing_generator: bool = False,
                  unknown_parameters: Optional[Sequence[str]] = None,
@@ -1448,16 +1442,6 @@
             return True
         return False

-    @deprecated('generator.close()', since='20200804')
-    def stop(self) -> None:  # pragma: no cover
-        """Stop iterating.
-
-        .. deprecated::
-           Use generator.close() instead.
-        """
-        pywikibot.output('Generator has been stopped.')
-        self.generator.close()
-
     def quit(self) -> None:
         """Cleanup and quit processing."""
         raise QuitKeyboardInterrupt

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/759717
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I4a72f6d7231a2accfd0f38d2d50ea338ebf5201c
Gerrit-Change-Number: 759717
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: JJMC89 <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to