jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/663720 )
Change subject: [bugfix] Fix test_messages tests
......................................................................
[bugfix] Fix test_messages tests
Family.codes (often) is a set and not a list
Change-Id: Ida156bfe9b5627e6aaf18284e50f257b1a25cdbb
---
M tests/site_tests.py
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 4158d05..96bc15c 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -243,14 +243,14 @@
months = ['january', 'february', 'march', 'april', 'may_long',
'june', 'july', 'august', 'september', 'october',
'november', 'december']
- lang1, lang2 = mysite.family.codes[1:3]
+ codes = list(mysite.family.codes)
+ lang1, lang2 = codes[0], codes[-1]
with self.subTest(messages='months', lang1=lang1, lang2=lang2):
- if lang1 == lang2:
- self.skipTest('lang1 and lang2 are equal ({})'.format(lang1))
self.assertLength(mysite.mediawiki_messages(months, lang1), 12)
self.assertLength(mysite.mediawiki_messages(months, lang2), 12)
- self.assertNotEqual(mysite.mediawiki_messages(months, lang1),
- mysite.mediawiki_messages(months, lang2))
+ if lang1 != lang2:
+ self.assertNotEqual(mysite.mediawiki_messages(months, lang1),
+ mysite.mediawiki_messages(months, lang2))
with self.subTest(messages='Test messages order'):
msg = mysite.mediawiki_messages(months, 'en')
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/663720
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ida156bfe9b5627e6aaf18284e50f257b1a25cdbb
Gerrit-Change-Number: 663720
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
