Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/662043 )
Change subject: [IMPR] raise a more informative KeyError in
NamespacesDict.__getitem__
......................................................................
[IMPR] raise a more informative KeyError in NamespacesDict.__getitem__
Bug: T273763
Change-Id: Ia81727988ee584edf79807ae3027197719998f0b
---
M pywikibot/site/_namespace.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
DannyS712: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
diff --git a/pywikibot/site/_namespace.py b/pywikibot/site/_namespace.py
index cbd7590..8d5bee2 100644
--- a/pywikibot/site/_namespace.py
+++ b/pywikibot/site/_namespace.py
@@ -330,7 +330,11 @@
@param key: namespace key
"""
if isinstance(key, (Namespace, int)):
- return self._namespaces[key]
+ try:
+ return self._namespaces[key]
+ except KeyError:
+ raise KeyError('{} is not a known namespace. Maybe you should '
+ 'clear the api cache.'.format(key))
namespace = self.lookup_name(key)
if namespace:
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/662043
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ia81727988ee584edf79807ae3027197719998f0b
Gerrit-Change-Number: 662043
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: DannyS712 <[email protected]>
Gerrit-Reviewer: Shizhao <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
