Xqt added a comment.

  Hi there.
  
  I adjusted the nightly version file path in rPWBC77ecbd1a7 
<https://phabricator.wikimedia.org/rPWBC77ecbd1a753a2b518d5be89c8627265caae92564>
 that Pywikibot could find the version information from https://pywikibot.org 
nightly dumps. Unfortunately there were  old bugs introduced with rPWBC7446058 
<https://phabricator.wikimedia.org/rPWBC7446058e814d1326fff537927940ed78a5a45a6a>
 in line 321 and 326 within the `getversion_nightly()` function (somewhat 
Pywikibot 2.0rc1): the path was bent and the the `strip()` methods were 
removed. Therefore the `getversion()` function falls back to the package 
version which gives something like that:
  
    {'tag': 'pywikibot/__init__.py', 'rev': '-1 (unknown)', 'date': 
'2024/04/28, 14:23:49', 'hsh': ''}
  
  which could improved by using the `pywikibot.__version__` information.
  
  @zhuyifei1999 made a patch for this issue. I'll try to add some tests soon.

TASK DETAIL
  https://phabricator.wikimedia.org/T363943

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zhuyifei1999, Xqt
Cc: Aklapper, Framawiki, Xqt, pywikibot-bugs-list, mevo, PotsdamLamb, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, 
Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to