JJMC89 created this task. JJMC89 added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION Since rPWBC891a720c09e6: [bugfix] No longer lazy load cookies <https://phabricator.wikimedia.org/rPWBC891a720c09e694e85113c2376c0f1613c89a31a6>, initializing APISite will attempt to login using cookies; therefore, any `Site()` can cause API requests for info. Example situation: 1. Do not configure pywikibot, and ensure the cache is clear. - This will default to test:wikipedia. 2. Run `t.py` - It will unnecessarily request info from test.wikipedia due to an unconditional `Site()`. - https://test.wikipedia.org/w/api.php?action=query&meta=siteinfo%7Cuserinfo&siprop=namespaces%7Cnamespacealiases%7Cgeneral&continue=&uiprop=blockinfo%7Chasmsg&maxlag=5&format=json - https://test.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=blockinfo%7Cgroups%7Chasmsg%7Cratelimits%7Crights&formatversion=2&rawcontinue=&maxlag=5&format=json name=t.py import pywikibot from pywikibot.comms.eventstreams import EventStream site = pywikibot.Site("en", "wikipedia") # site other than the default stream = EventStreams("revision-create", site=site) # unnecessarily requests data from the default site name=trace pywikibot/comms/eventstreams.py:146: in __init__ self._site = kwargs.pop('site', Site()) pywikibot/__init__.py:1339: in Site _sites[key] = interface(code=code, fam=fam, user=user) pywikibot/site/_apisite.py:127: in __init__ self.login(cookie_only=True) pywikibot/site/_apisite.py:384: in login if self.userinfo['name'] == self.user(): pywikibot/site/_apisite.py:543: in userinfo uidata = uirequest.submit() TASK DETAIL https://phabricator.wikimedia.org/T335720 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JJMC89 Cc: Aklapper, pywikibot-bugs-list, Xqt, JJMC89, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
