JJMC89 claimed this task. JJMC89 added a comment.
The 3.5 docs don't have the note about being introduced in 3.5.2, which is what I used as a reference. https://docs.python.org/3.5/library/typing.html#typing.DefaultDict The typing module was provisional before Python 3.7. Options: 1. Add typing-extensions (PyPI <https://pypi.org/project/typing-extensions/>; GitHub <https://github.com/python/typing/tree/master/typing_extensions>) as a dependency. 2. Add typing-extensions as a dependency for Python < 3.7. 3. Reqire Python >= 3.5.3 4. Workaround typing issues - in this case, use Dict instead of DefaultDict Unless we can get typing-extensions installed on Toolfoge, options 1 and 2 are out. Option 2 wouldn't allow the use of types introduced in Python 3.7.2+ (e.g. TypedDict). Option 3 could still leave us with cases where workarounds still need to be applied for typing classes introduced later, but fewer cases than supporting Python < 3.5.3. Since Toolforge has Python 3.5.3, limiting support to Python 3.5.3+ could be reasonable if there aren't major distros with default Python < 3.5.3. TASK DETAIL https://phabricator.wikimedia.org/T257770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JJMC89 Cc: Aklapper, JJMC89, Xqt, pywikibot-bugs-list, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
