[Pywikipedia-bugs] [Maniphest] [Created] T208484: TestIsbnWikibaseBot.test_isbn_format is failing with TypeError

[Dalba]

Dalba created this task. Dalba added projects: Pywikibot, Pywikibot-tests, Pywikibot-Wikidata. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

https://travis-ci.org/wikimedia/pywikibot/jobs/449178336#L3750

____________ ERROR at setup of TestIsbnWikibaseBot.test_isbn_format ____________
cls = <class 'tests.isbn_tests.TestIsbnWikibaseBot'>
    @classmethod
    def setUpClass(cls):
        """Set up test class."""
        super(TestIsbnWikibaseBot, cls).setUpClass()
    
        # Check if the unit test item page and the property both exist
        item_ns = cls.get_repo().item_namespace
        for page in cls.get_site().search('IsbnWikibaseBotUnitTest'
                                          total=1, namespaces=item_ns):
            cls.test_page_qid = page.title()
            item_page = ItemPage(cls.get_repo(), page.title())
>           for pid, claims in item_page.get()['claims'].items():
tests/isbn_tests.py:253: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pywikibot/page.py:4449: in get
    data = super(ItemPage, self).get(force, *args, **kwargs)
pywikibot/page.py:3949: in get
    c = Claim.fromJSON(self.repo, claim)
pywikibot/page.py:4886: in fromJSON
    claim.type, lambda value, site: value)(value, site)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
value = '097522980x', site = DataSite("test", "wikidata")
        'wikibase-item': lambda value, site:
>           ItemPage(site, 'Q' + str(value['numeric-id']))
        'wikibase-property': lambda value, site:
            PropertyPage(site, 'P' + str(value['numeric-id']))
        'commonsMedia': lambda value, site:
            FilePage(pywikibot.Site('commons', 'commons'), value),  # T90492
        'globe-coordinate': pywikibot.Coordinate.fromWikibase
        'geo-shape': pywikibot.WbGeoShape.fromWikibase
        'tabular-data': pywikibot.WbTabularData.fromWikibase
        'time': pywikibot.WbTime.fromWikibase
        'quantity': pywikibot.WbQuantity.fromWikibase
        'monolingualtext': lambda value, site:
            pywikibot.WbMonolingualText.fromWikibase(value)
    }
E   TypeError: string indices must be integers
pywikibot/page.py:4813: TypeError
------------------------------ Captured log setup ------------------------------
logging.py                 109 VERBOSE  Found 1 wikidata:test processes running, including this one.
_____________ ERROR at setup of TestIsbnWikibaseBot.test_isbn_to13 _____________
cls = <class 'tests.isbn_tests.TestIsbnWikibaseBot'>
    @classmethod
    def setUpClass(cls):
        """Set up test class."""
        super(TestIsbnWikibaseBot, cls).setUpClass()
    
        # Check if the unit test item page and the property both exist
        item_ns = cls.get_repo().item_namespace
        for page in cls.get_site().search('IsbnWikibaseBotUnitTest'
                                          total=1, namespaces=item_ns):
            cls.test_page_qid = page.title()
            item_page = ItemPage(cls.get_repo(), page.title())
>           for pid, claims in item_page.get()['claims'].items():
tests/isbn_tests.py:253: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
pywikibot/page.py:4449: in get
    data = super(ItemPage, self).get(force, *args, **kwargs)
pywikibot/page.py:3949: in get
    c = Claim.fromJSON(self.repo, claim)
pywikibot/page.py:4886: in fromJSON
    claim.type, lambda value, site: value)(value, site)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
value = '097522980x', site = DataSite("test", "wikidata")
        'wikibase-item': lambda value, site:
>           ItemPage(site, 'Q' + str(value['numeric-id']))
        'wikibase-property': lambda value, site:
            PropertyPage(site, 'P' + str(value['numeric-id']))
        'commonsMedia': lambda value, site:
            FilePage(pywikibot.Site('commons', 'commons'), value),  # T90492
        'globe-coordinate': pywikibot.Coordinate.fromWikibase
        'geo-shape': pywikibot.WbGeoShape.fromWikibase
        'tabular-data': pywikibot.WbTabularData.fromWikibase
        'time': pywikibot.WbTime.fromWikibase
        'quantity': pywikibot.WbQuantity.fromWikibase
        'monolingualtext': lambda value, site:
            pywikibot.WbMonolingualText.fromWikibase(value)
    }
E   TypeError: string indices must be integers
pywikibot/page.py:4813: TypeError

TASK DETAIL

https://phabricator.wikimedia.org/T208484

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Aklapper, pywikibot-bugs-list, Dalba, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs