[Pywikipedia-bugs] [Maniphest] [Created] T158032: InvalidTitle not raised by getCategoryLinks

[Dalba]

Dalba created this task. Dalba added projects: Pywikibot-tests, Pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

<tests.textlib_tests.TestTemplatesInCategory testMethod=test_templates> is failing:

____________________ TestTemplatesInCategory.test_templates ____________________

self = <tests.textlib_tests.TestTemplatesInCategory testMethod=test_templates>

    def test_templates(self):

        """Test normal templates inside category links."""

        self.site = self.get_site()

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|Foo}}]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|Foo}}|bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:{{P1|{{P2|L33t|Foo}}}}|bar]]',

            self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}bar]][[Category:Wiki{{P2||pedia}}]]',

            self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='bar'),

             pywikibot.page.Category(self.site, 'Wikipedia')])

        self.assertEqual(textlib.getCategoryLinks(

            '[[Category:Foo{{!}}and{{!}}bar]]', self.site, expand_text=True),

            [pywikibot.page.Category(self.site, 'Foo', sortKey='and|bar')])

        self.assertRaises(pywikibot.InvalidTitle, textlib.getCategoryLinks,

>                         '[[Category:nasty{{{!}}]]', self.site)

E       AssertionError: InvalidTitle not raised by getCategoryLinks

tests/textlib_tests.py:302: AssertionError

TASK DETAIL

https://phabricator.wikimedia.org/T158032

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Aklapper, pywikibot-bugs-list, Dalba, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs