https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256705

Kubilay Kocak <ko...@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(timp87
                   |                            |@gmail.com)
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open
            Summary|devel/py-jsonnet: python    |[NEW] devel/py-jsonnet:
                   |bindings for jsonnet        |Python bindings for
                   |                            |Jsonnet: The data
                   |                            |templating language
                 CC|                            |python@FreeBSD.org,
                   |                            |tim...@gmail.com

--- Comment #1 from Kubilay Kocak <ko...@freebsd.org> ---
Please confirm this passes QA across multiple Python versions.

Initial review:

 - strip command is hardcoded (38)
 - What is gmake used for and is it required? Upstream install directions
specify only requiring pip install, which should not require make/gmake. If
not, BINARY_ALIAS over REINPLACE
 - Upstream provides and utilises a test suite [1], please hook this up in a
do-test target and add TEST_DEPENDS if required

[] setup.py:test_suite="python._jsonnet_test",

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to