First of all my apologies for the wasted time... specially for the Release Team that was so fast on unblocking requests 2.4.3-3.
On Wednesday 12 November 2014 23:43:58 Tianon Gravi wrote: > Any ideas? Do we need to include some kind of further patch in > python-docker, or was the patch to requests possibly not complete? I fixed this in requests 2.4.3-4 (RFS already sent to Piotr). The only changes needed are here: http://anonscm.debian.org/viewvc/python-modules/packages/requests/trunk/debian/patches/04_make-requests.packages.urllib3-same-as-urllib3.patch?view=markup&pathrev=31441 The package build fine twice in a row in a pbuilder chroot. This time, beyond, running requests' tests I also used these: ------------------[test_requests.py]-------------------------- from __future__ import print_function import requests import requests.packages.urllib3 import urllib3 assert requests.packages.urllib3 is urllib3 assert requests.packages.urllib3 == urllib3 from requests.packages.urllib3.util import get_host from urllib3.util import get_host as get_host_u3 assert get_host is get_host_u3 from requests.packages.urllib3.util.timeout import Timeout as T1 from urllib3.util.timeout import Timeout as T2 assert T1 is T2 -------------------------------------------------------------- ------------------[test_docker.py]---------------------------- from __future__ import print_function import os import docker c = docker.Client(base_url=os.getenv('DOCKER_HOST')) print(c.version()) -------------------------------------------------------------- I ran them both on Python 2 and Python 3. Also, I noticed that linking urllib3 inside requests.packages is not needed anymore, but I did not removed *.links due to the freeze, to keep changes as small as possible. Of course, I will wait before asking for an unblock. I want to try Kind regards, P.S. Unfortunately I will be off-line during the weekend, so feel free to work on requests if it's needed. I'll be back on monday. -- Daniele Tricoli 'Eriol' http://mornie.org _______________________________________________ Python-modules-team mailing list Python-modules-team@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
