Your message dated Tue, 07 May 2013 23:32:52 +0200
with message-id <2557800.rbbyCvFlit@mornie>
and subject line
has caused the Debian Bug report #699844,
regarding requests mis-treats 303 responses due to a typo
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
699844: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699844
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: python-requests
Severity: important
Tags: patch
thanks
I've attached upstream's fix. Some bits:
Caused by using `is' on ints, rather then "==". Upstream bug 1156[1],
fixed in commit b07c1ebd859a32e1203c1d4ef27f1fb9e154e55e (attached).
This violates a "SHOULD" in the HTTP/1.1 RFC, and it'd be really nice to
get this fixed for wheezy, if there is a way to get such a small change
in.
Thanks,
Paul
[1]: https://github.com/kennethreitz/requests/issues/1156
[2]:
https://github.com/kennethreitz/requests/commit/b07c1ebd859a32e1203c1d4ef27f1fb9e154e55e
--
.''`. Paul Tagliamonte <[email protected]>
: :' : Proud Debian Developer
`. `'` 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87
`- http://people.debian.org/~paultag
From b07c1ebd859a32e1203c1d4ef27f1fb9e154e55e Mon Sep 17 00:00:00 2001
From: Yehuda Sadeh <[email protected]>
Date: Thu, 31 Jan 2013 10:32:00 -0800
Subject: [PATCH] Fix POST 303 redirect resonse handling
This fixes issue #1156.
Signed-off-by: Yehuda Sadeh <[email protected]>
---
requests/sessions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/requests/sessions.py b/requests/sessions.py
index de3f5b7..c0840f2 100644
--- a/requests/sessions.py
+++ b/requests/sessions.py
@@ -106,7 +106,7 @@ def resolve_redirects(self, resp, req, stream=False, timeout=None, verify=True,
url = urljoin(resp.url, requote_uri(url))
# http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.4
- if resp.status_code is codes.see_other and req.method != 'HEAD':
+ if resp.status_code == codes.see_other and req.method != 'HEAD':
method = 'GET'
# Do what the browsers do, despite standards...
--
1.7.10
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Package: python-requests
Version: 1.2.0-1
Since it's fixed upstream, and python-requests 1.2.0-1 is in experimental, I'm
closing this now.
Cheers,
--
Daniele Tricoli 'Eriol'
http://mornie.org
signature.asc
Description: This is a digitally signed message part.
--- End Message ---
_______________________________________________
Python-modules-team mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team
