https://github.com/python/cpython/commit/ee2775cfae6bce18541e18797b67e09f2d12f72b
commit: ee2775cfae6bce18541e18797b67e09f2d12f72b
branch: main
author: Max Bachmann <[email protected]>
committer: kumaraditya303 <[email protected]>
date: 2026-04-09T18:50:50+05:30
summary:
gh-148274: properly handle result from `PyObject_VisitManagedDict` (#148275)
files:
M Modules/_asynciomodule.c
M Modules/_testcapimodule.c
M Objects/typevarobject.c
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
index fda7d1ef934da0..9679a7dde31b0d 100644
--- a/Modules/_asynciomodule.c
+++ b/Modules/_asynciomodule.c
@@ -944,8 +944,7 @@ FutureObj_traverse(PyObject *op, visitproc visit, void *arg)
Py_VISIT(fut->fut_cancel_msg);
Py_VISIT(fut->fut_cancelled_exc);
Py_VISIT(fut->fut_awaited_by);
- PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
- return 0;
+ return PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
}
/*[clinic input]
@@ -2425,8 +2424,7 @@ TaskObj_traverse(PyObject *op, visitproc visit, void *arg)
Py_VISIT(fut->fut_cancel_msg);
Py_VISIT(fut->fut_cancelled_exc);
Py_VISIT(fut->fut_awaited_by);
- PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
- return 0;
+ return PyObject_VisitManagedDict((PyObject *)fut, visit, arg);
}
/*[clinic input]
diff --git a/Modules/_testcapimodule.c b/Modules/_testcapimodule.c
index aa12db20908b97..3ebe4ceea6a72e 100644
--- a/Modules/_testcapimodule.c
+++ b/Modules/_testcapimodule.c
@@ -3280,9 +3280,8 @@ typedef struct {
} ManagedDictObject;
int ManagedDict_traverse(PyObject *self, visitproc visit, void *arg) {
- PyObject_VisitManagedDict(self, visit, arg);
Py_VISIT(Py_TYPE(self));
- return 0;
+ return PyObject_VisitManagedDict(self, visit, arg);
}
int ManagedDict_clear(PyObject *self) {
diff --git a/Objects/typevarobject.c b/Objects/typevarobject.c
index b5413ee37a9358..c2b8ee43119cb1 100644
--- a/Objects/typevarobject.c
+++ b/Objects/typevarobject.c
@@ -500,8 +500,7 @@ typevar_traverse(PyObject *self, visitproc visit, void *arg)
Py_VISIT(tv->evaluate_constraints);
Py_VISIT(tv->default_value);
Py_VISIT(tv->evaluate_default);
- PyObject_VisitManagedDict(self, visit, arg);
- return 0;
+ return PyObject_VisitManagedDict(self, visit, arg);
}
static int
@@ -1195,8 +1194,7 @@ paramspec_traverse(PyObject *self, visitproc visit, void
*arg)
Py_VISIT(ps->bound);
Py_VISIT(ps->default_value);
Py_VISIT(ps->evaluate_default);
- PyObject_VisitManagedDict(self, visit, arg);
- return 0;
+ return PyObject_VisitManagedDict(self, visit, arg);
}
static int
@@ -1692,8 +1690,7 @@ typevartuple_traverse(PyObject *self, visitproc visit,
void *arg)
Py_VISIT(tvt->name);
Py_VISIT(tvt->default_value);
Py_VISIT(tvt->evaluate_default);
- PyObject_VisitManagedDict(self, visit, arg);
- return 0;
+ return PyObject_VisitManagedDict(self, visit, arg);
}
static int
_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/python-checkins.python.org
Member address: [email protected]
