New submission from SilentGhost <ghost....@gmail.com>: In the course of fixing #10896 I've noticed a few things:
1. --ignore-dir='$prefix' doesn't work on windows. I don't know if it has to, there is no information in docs regarding it at all. It does work on Unix. 2. The way module check is done is inefficient. 3. I'm not sure if filename could ever get the value of None in _Ignore.names (there is check for that though) 4. it's not clear why _Ignore initialised with default values of None, that path was never exercised and while I've added a test for it, I'm actually not sure if it's needed. 5. general clean up was needed for the code dealing with ignoring. Attached is the patch. The only change, that I consider beneficial, is that the ignored dir doesn't have actually be a directory. ---------- components: Library (Lib) files: trace_ignore.diff keywords: easy, patch messages: 126271 nosy: SilentGhost, belopolsky, vrutsky priority: normal severity: normal status: open title: Improvements to trace._Ignore versions: Python 2.7, Python 3.1, Python 3.2 Added file: http://bugs.python.org/file20407/trace_ignore.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10908> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
