Éric Araujo <mer...@netwok.org> added the comment:

Patch looks good.  Can you add tests for the new functionality?  (This is 
listed in the link I gave you :)

Note: this code

    if 'aliases' in kwargs:
        aliases = kwargs.pop('aliases')
    else:
        aliases = ()

can be shortened to

    aliases = kwargs.pop('aliases', ())

----------
versions: +Python 3.3 -Python 3.2

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9234>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to