Ned Deily <n...@acm.org> added the comment: One review comment: the patch adds a new exception class that is used for the errors that are now additionally detected. Elsewhere plistlib uses non-specific exception classes like ValueError. If starting from scratch, it might be better to consistently use a specific exception class but that would create incompatibilities if changed now. I don't see a compelling need to add one now just for these errors. (But, if kept, it should be added to the docs.) Otherwise, looks good to me.
Thanks for taking this on! ---------- nosy: +ned.deily, ronaldoussoren stage: unit test needed -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue985064> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
