Marc-Andre Lemburg <m...@egenix.com> added the comment: Alexander Belopolsky wrote: > > Alexander Belopolsky <belopol...@users.sourceforge.net> added the comment: > > Attached patch addresses the issue by using -1 instead of None for missing > codes. Comparison of generated encoding files to those in Lib/encodings > shows only whitespace changes except one which appears to be a change on the > unicode.org side:
Please use a global constant instead of the literal -1, e.g. MISSING_CODE. Thanks. > diff -b build/koi8_u.py ../../Lib/encodings/koi8_u.py > 1c1 > < """ Python Character Mapping Codec koi8_u generated from > 'MAPPINGS/VENDORS/MISC/KOI8-U.TXT' with gencodec.py. > --- >> """ Python Character Mapping Codec koi8_u generated from >> 'python-mappings/KOI8-U.TXT' with gencodec.py. > 221c221 > < '\u0491' # 0xAD -> CYRILLIC SMALL LETTER GHE WITH UPTURN > --- >> '\u0491' # 0xAD -> CYRILLIC SMALL LETTER UKRAINIAN GHE WITH UPTURN > 237c237 > < '\u0490' # 0xBD -> CYRILLIC CAPITAL LETTER GHE WITH UPTURN > --- >> '\u0490' # 0xBD -> CYRILLIC CAPITAL LETTER UKRAINIAN GHE WITH UPTURN > 308d307 > < That's just a comment and doesn't change the semantics of the codec. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10552> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
