anatoly techtonik <techto...@gmail.com> added the comment: Fixed docstring.
http://codereview.appspot.com/2874041/diff/2001/cmd.py File cmd.py (right): http://codereview.appspot.com/2874041/diff/2001/cmd.py#newcode55 cmd.py:55: :param distutils.dist.Distribution dist: distribution to work with On 2010/11/08 18:47:39, merwok wrote: > > Including this in another patch is too much work to ever happen. > We’ll have to revert it before committing then. > > What Python uses? > Something like “*dist* is an instance of blah”. I thought Python uses all Sphinx capabilities. Done. http://codereview.appspot.com/2874041/diff/2001/command/upload.py File command/upload.py (right): http://codereview.appspot.com/2874041/diff/2001/command/upload.py#newcode53 command/upload.py:53: if not self.username and self.distribution.username: On 2010/11/08 18:47:39, merwok wrote: > This is a crazy case. That's why I don't want to make distinction between "None" username and empty username. They are both the same in this context. http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py File tests/test_register.py (right): http://codereview.appspot.com/2874041/diff/2001/tests/test_register.py#newcode165 tests/test_register.py:165: inputs = RawInputs('1', 'tarek', 'n') On 2010/11/08 18:47:39, merwok wrote: > It looks like you’re replying to “username” and “save your login” but not > “password”. That's magically patched in setUp method. http://codereview.appspot.com/2874041/ ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue10361> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
