Éric Araujo <[email protected]> added the comment: Thank you for the report and patch. Some bug tracker tips:
1) It’s possible to replace a file, so that there is always one bug.py and one diff, which is easier for reviewers to understand than a long list of files (possibly all with the same name). It’s also possible to remove obsolete files so that nobody loses time commenting on them. 2) Can you turn your bug reproducer into a patch for Lib/test/test_sqlite.py? 3) Please follow guidelines on http://www.python.org/dev/patches/ to make patches. Regarding the code itself: a) I don’t understand why you added quotes around names that seemed fine without them (for example in “SELECT name”). b) I find the master line difficult to read: “q += ",".join(["'||quote(\"" + col.replace('"', '""') + "\")||'" for col in column_names])”. You’re using backslashes since there are both single and double quotes, but I would use triple-quoted strings here. I also find string formatting more readable than string concatenation: 'blah blah "{}" blah'.format(thing.replace('"', '""')). c) Minor style thing: A generator expression works as fine as a list comprehension in str.join (that is, ",".join(i for i in source) == ";".join([i for i in source])). Thanks again! ---------- nosy: +eric.araujo _______________________________________ Python tracker <[email protected]> <http://bugs.python.org/issue9750> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
