Walter Woods <woodswal...@gmail.com> added the comment: Hi David,
I like most of your patch (especially since it has unit tests), and if people like yourself are actually using the current functionality then that's fine, but one recommendation: why not change this line: if not headers or isinstance(headers, str): To also include the clause ``or getattr(headers, '__iter__', False)``. That way, other default values (such as numbers) would work as expected rather than throw an error. What do you think of that? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8572> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
