Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment:

The patch is good, except for two things:
when PyObject_Repr() fails, the word 'item' is put instead. This is a good 
idea, but PyErr_Clear() should be called as soon as possible, before calling 
another API function.
Also, the error message can grow without bounds. It would be better to limit 
the size of the string.

----------
nosy: +amaury.forgeotdarc

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue4510>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to