Brian Curtin <cur...@acm.org> added the comment:

I'm looking into the TODO details right now, but the patch as-is didn't pass 
for me.

The last line of test_communicate_timeout fails on Windows 7 with 
"pineapple\r\npear\r\n" not matching "pineapple\npear\n". Creating the Popen 
object with universal_newlines=1 fixes the issue locally (haven't tried on 
other OSes), but it should probably follow the convention laid out in 
test_universal_newlines.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue5673>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to