James Lee <j...@jbit.net> added the comment:

Thanks for the update... The link was actually just a "diff to previous" of the 
changelist that caused the problem (r56987), sorry for the confusion. :)

Attached is a quick and dirty unittest complete with some test files. It only 
tests the format of the file though, not any of the additional information 
returned.

With an untouched sndhdr.py it finds the issue reported, and with 
sndhdr-fix.patch applied it reports only one issue:

Traceback (most recent call last):
  File "test_sndhdr.py", line 22, in test_aiff
    self.assertEqual(ret[0], 'aiff')
AssertionError: b'aiff' != 'aiff'

I'm thinking that on line 65 of sndhdr.py the b'aiff' should be just 'aiff' 
(like everything else). At least I can't see a reason for it to be different. 
(Changing this fixes the unittest issue)

Cheers

----------
Added file: http://bugs.python.org/file17986/test_sndhdr.tar.gz

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue9243>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to