Antoine Pitrou <pit...@free.fr> added the comment:

Oh, nice!

> I was wondering if I should merge PyThread_acquire_lock_timed with my
> new PyThread_acquire_lock_timed_intr, since PyThread_acquire_lock_timed 
> wasn't available in 3.1.

Yes, I think you should.

I haven't tried the patch, but it seems you got the logic right. There's a 
problem sometimes that you're using 2 spaces for indent rather than 4. Also, 
you forgot to update the RLock implementation in _threadmodule.c (and perhaps 
add another test for it).

(there are other modules which use the PyThread_acquire_lock API, but most of 
the time the locks are held for a short time (and shouldn't deadlock), which 
makes converting them less of a priority)

----------
versions:  -Python 3.1

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue8844>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to