Alexander Belopolsky <belopol...@users.sourceforge.net> added the comment:
I've noticed that your patch changes >>> math.factorial(2.**63) Traceback (most recent call last): File "<stdin>", line 1, in <module> OverflowError: Python int too large to convert to C long to >>> math.factorial(2.**63) Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: factorial() not defined for negative values While the error message is wrong in both cases, I think OverflowError is a better exception in this case and there should not be a difference between math.factorial(2.**63) and math.factorial(2**63) behavior. ---------- nosy: +belopolsky _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8692> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com