A.M. Kuchling <li...@amk.ca> added the comment: Thanks for the patches! Two comments on the addchstr change:
* I think that, instead of checking for a list, the method should accept any Python sequence; a tuple is perfectly reasonable, for example, and if the code is changed to use PyCurses_ConvertToChType() instead of PyInt_Check(), it will accept a list of integers, a mixed list of ints and character strings, and even just strings. * the documentation and error messages currently try to paper over all of the curses variants of addchstr(), waddchstr(), mvwaddchstr(), ..., covering them all up under the addchstr name. This means that your submitted documentation patch is too detailed; it should look more like the insnstr() docs, which has [y,x,] as optional, and the text says something like "Moves to y,x if specified, and then ...'. The color_set() changes look OK; I'm going to try to break them out into a separate patch and commit them on their own. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5368> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
