Brian Curtin <cur...@acm.org> added the comment:

Can you add your test to Lib/test/test_pdb.py?

If the test fails the "hello world" script won't be removed, it won't make it 
to os.remove(). You'll need to make sure the file gets deleted in any case. 
Could use a temporary file.

Can you condense the cmd stuff into less lines? Super minor thing, but it's all 
short lines anyways.

Rather than testing using failIf, assertFalse is a better alternative. In 2.7 
there is assertIn which would be ideal for this test, but this will go into 2.6 
as well.

----------
stage: test needed -> patch review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7750>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to