Antoine Pitrou <pit...@free.fr> added the comment: > Actually I see different macros which do the same thing: I will consider > reusing STRINGLIB_CMP to re-define PyUNICODE_MATCH and PySTRING_MATCH > (or create aliases if they have the same signature).
STRINGLIB_CMP, as the name implies, should only be used by stringlib. (anything which doesn't start with Py* shouldn't be exported in the official include files) > But don't you think we should do this incrementally, i.e. commit the > current patch before refactoring more code? Well, if STRINGLIB_CMP isn't used anymore, removing it should be part of the current issue. There's no reason to leave dead code in the source tree. I agree that further cleanups can be part of another issue. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7462> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
