Ezio Melotti <ezio.melo...@gmail.com> added the comment: In r64791, BaseException gained a new __unicode__ method that does the equivalent of the following things: * if the number of args is 0, returns u'' * if it's 1 returns unicode(self.args[0]) * if it's >1 returns unicode(self.args)
Before this, BaseException only had a __str__ method, so unicode(e) (with e being an exception derived from BaseException) called: * e.__str__().decode(), if e didn't implement __unicode__ * e.__unicode__(), if e implemented an __unicode__ method Now, all the derived exceptions that don't implement their own __unicode__ method inherit the "generic" __unicode__ of BaseException, and they use that instead of falling back on __str__. This is generally ok if the numbers of args is 0 or 1, but if there are more args, there's usually some specific formatting in the __str__ method that is lost when BaseException.__unicode__ returns unicode(self.args). Possible solutions: 1) implement a __unicode__ method that does the equivalent of calling unicode(str(self)) (i.e. converting to unicode the message returned by __str__ instead of converting self.args); 2) implement a __unicode__ method that formats the message as __str__ for all the exceptions with a __str__ that does some specific formatting; Attached there's a proof of concept (issue6108.diff) where I tried to implement the first method with UnicodeDecodeError. This method can be used as long as __str__ always returns only ascii. The patch seems to work fine for me (note: this is my first attempt to use the C API). If the approach is correct I can do the same for the other exceptions too and submit a proper patch. ---------- assignee: -> ezio.melotti keywords: +patch Added file: http://bugs.python.org/file15529/issue6108.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue6108> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
