Scott Dial <sc...@scottdial.com> added the comment: The design of your patch makes a lot of sense. I found that your patch uncovered a problem with using the ThreadingMixin (which is ultimately not necessary as long as the whole SocketServer is in its own thread). I rewrote the SimpleIMAPHandler to timeout in a timely manner and for the reap_server() to actually ensure that all threads have been shutdown.
I ended up rewriting my patch in steps towards yours before I uncovered why I was getting threads alive at shutdown. In that vein, the patch I am attaching uses the "with reaped_server(hdlr) as server:" technique, but it could be converted to use an attribute instead. I find using "with" easier to read and less error prone (failing shutdown the server and thread because human error or an uncaught exception). ---------- Added file: http://bugs.python.org/file15472/test_imaplib_issue5949-2.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5949> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
