Eric Smith <e...@trueblade.com> added the comment: I think you need to put an assert before the line with bufflen-x, since that's the calculation you're trying to ensure doesn't underflow. And I guess that technically you should inspect the result of PyOS_snprintf for an error, but given that we know the buffer sizes it's not so important.
Other than that, looks good. Sorry for the piecemeal patch review. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7413> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
