Eric Smith <e...@trueblade.com> added the comment: The patch looks okay to me, and works on 2.7. Although it's slightly out of date with respect to line numbers, it still applies cleanly.
My trivial suggestions are that I'd replace: x += PyOS_snprintf(buffer + 8, bufflen - 8, ".%06d", us); with x += PyOS_snprintf(buffer + x, bufflen - x, ".%06d", us); in the extremely unlikely event that the time format string ever changes. I'd probably also throw in an assert(bufflen >= x). But these 2 points are nits. ---------- assignee: amaury.forgeotdarc -> components: +Extension Modules nosy: +eric.smith priority: -> normal stage: -> patch review type: -> behavior versions: +Python 2.6, Python 2.7 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue7413> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
