Antoine Pitrou <pit...@free.fr> added the comment: A couple of points: - if the method is Windows-specific, I don't think it shouldn't bear a name as generic as "read_registry()". There are "registries" on other systems. - the method should probably raise early on non-Windows systems (raise NotImplementedError?) - please fix the coding style; don't collapse a "try", "except" or "finally" and the following statement on a single line - in the tests, rather than defining an empty test case on non-Windows systems, make the tests skip (for example, call self.skipTest()
---------- nosy: +pitrou priority: -> normal stage: -> patch review type: -> feature request versions: +Python 3.2 -Python 3.1 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue4969> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
