Benjamin Peterson <benja...@python.org> added the comment: Patch review:
- It needs docs and tests. - In addcleanup_convert, Py_FatalError calls abort, so there isn't really a point of returning -1; - Also in the function, you need to call destr() in the case that PyList_Append fails. ---------- nosy: +benjamin.peterson _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue6012> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
