Amaury Forgeot d'Arc <amaur...@gmail.com> added the comment: The current patch is not correct, because os.path.splitext returns the extension with the leading dot.
Here is another patch that simplifies the code (os.path.splitext is guaranteed to return two strings) It also adds the first unit test for msilib. There is an unresolved issue: what is make_short('foo.2.txt') supposed to return? FOO.2.TXT or FOO~1.TXT ? ---------- nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file13873/msilib-2.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1128> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com