Eric Smith <e...@trueblade.com> added the comment: This looks okay to me (although since it's not hooked up I haven't tested it). I particularly like that it doesn't allow leading whitespace, and that the caller no longer has to remember errno (forgetting to set and/or test it have both caused me problems in the past).
Does the whitespace change cause any problems for any internal code? I wouldn't think so, but I haven't looked at it. As long as you're at it, I'd suggest deprecating PyOS_ascii_*. ---------- stage: -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5914> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com