Eric Smith <e...@trueblade.com> added the comment: The doc patch doesn't apply cleanly for me.
There are a number of code cleanups in the patch, like 0->False, 1->True, the improvement of the params to path(), improvement in isabs(), etc. I think these cleanups should be made in a separate patch, so that it's easier to evaluate what's really involved in this change. I'd be happy to do that, and produce the patches, if you could produce a clean patch. The docstring for splitdrive() should be indented, see PEP 257. Also, the code snippet in that docstring is wrong, it uses 'split' where it should be 'result', I think. I haven't worked my way through all of the code and tests, yet. ---------- nosy: +eric.smith _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5799> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
